First version of SaveBlock3 in debug menu #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkmnsnfrn
force-pushed
the
rhh-saveblock-3
branch
from
8846d81 to
9ab829e
Compare
mrgriffin
requested changes
Feb 9, 2024
include/save.h
Outdated
Comment on lines
20
to
21
| #define SECTOR_ID_SAVEBLOCK2_START 14 | ||
| #define SECTOR_ID_SAVEBLOCK2_END 27 |
There was a problem hiding this comment.
I think this has slipped in from a backup-save removal commit?
There was a problem hiding this comment.
No, this is me trying to guess what sectors these end in for use in CheckSaveBlock2Size.
There was a problem hiding this comment.
Ah! I think CheckSaveBlock2Size was fine, there's just a single sector dedicated to SaveBlock2 (it's sector 0) :)
Changed value of MaxSb3Size Co-authored-by: Martin Griffin <[email protected]>
mrgriffin
approved these changes
Feb 9, 2024
mrgriffin
added a commit
that referenced
this pull request
Feb 10, 2024
* SaveBlock3 in sector footers * Update load_save.c Since mgriffin is currently not available I took the liberty to edit the file. Hope it's fine. * SaveBlock3 in debug menu (#3) --------- Co-authored-by: DizzyEggg <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: psf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fairly certain this isn't the _right solution, but I figured it's a start. Need to figure out what
maxSb3Sizeshould be.